Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check for decimal format in cast expr (#20836) #21477

Merged
merged 6 commits into from
Jan 25, 2021
Merged

planner: check for decimal format in cast expr (#20836) #21477

merged 6 commits into from
Jan 25, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20836 to release-4.0

What problem does this PR solve?

Issue Number: close #20295

Problem Summary: There's no check for decimal format in cast expressions in TiDB.

select cast( (select sum(a) from t1) as decimal(65,65));
select CONVERT( 2, DECIMAL(62,60) ) ;
select CONVERT( 2, DECIMAL(66,29) ) ;

What is changed and how it works?

  • Check for decimal format in cast expressions during Preprocess.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Add checks for decimal format in cast expressions.

@dyzsr @ti-srebot
cherry pick pingcap#20836 to release-4.0
9e9dd77 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Dec 3, 2020
Merged
@ti-srebot ti-srebot added this to the 4.0.0 milestone Dec 3, 2020
@ti-srebot
Copy link
Contributor Author

@dyzsr you're already a collaborator in bot's repo.

lzmhhh123
lzmhhh123 reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2020
ichn-hu
ichn-hu approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 7, 2020
@jebter jebter modified the milestones: 4.0.0, v4.0.11 Jan 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 14, 2021

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 18, 2021

/run-all-tests

@zz-jason zz-jason added the type/bugfix This PR fixes a bug. label Jan 25, 2021
@ti-srebot ti-srebot removed the status/LGT2 Indicates that a PR has LGTM 2. label Jan 25, 2021
@ti-srebot ti-srebot added the status/LGT3 The PR has already had 3 LGTM. label Jan 25, 2021
@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 22359
  • 20981
  • 21323
  • 21329
  • 21404
  • 21443
  • 21473

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 66e24c3 into pingcap:release-4.0 Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@zz-jason zz-jason zz-jason approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@dyzsr dyzsr

Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @qw4990 @zz-jason @lzmhhh123 @ichn-hu @jebter @dyzsr